Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21563 )
Change subject: IMPALA-13194: Fast-serialize position delete records ...................................................................... Patch Set 3: (8 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21563/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21563/1//COMMIT_MSG@13 PS1, Line 13: e > Not yet done :) Now it's really done. Hopefully.. :) http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/iceberg-position-delete-collector.h File be/src/runtime/iceberg-position-delete-collector.h: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/iceberg-position-delete-collector.h@30 PS2, Line 30: /// serializing them to outbound row batches. The serialization algorithm > Can you add the layout from the commit message? Done http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/iceberg-position-delete-collector.h@63 PS2, Line 63: l_ = > This could be called inside Close and made private. Done http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21563/1/be/src/runtime/krpc-data-stream-sender.cc@943 PS1, Line 943: i64 > I think it would be an improvement, for example for reading "ch.get()" - if Done http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/krpc-data-stream-sender.cc@188 PS2, Line 188: light. This is expect > It could be private. Right now it's not used anywhere else and I don't like Done http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/outbound-row-batch.h File be/src/runtime/outbound-row-batch.h: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/outbound-row-batch.h@30 PS2, Line 30: MemTracker; > Is this really needed? Done http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/outbound-row-batch.h@68 PS2, Line 68: 'compres > Maybe PrepareForSend() would be clearer? It seem counter-intuitive for Fina Done http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/row-batch.cc File be/src/runtime/row-batch.cc: http://gerrit.cloudera.org:8080/#/c/21563/2/be/src/runtime/row-batch.cc@266 PS2, Line 266: RETURN_IF_ERROR(output_batch->PrepareForSend(row_desc_->tuple_descriptors().size(), > optional: I think that it would be useful to move Finalize (and compression This will be a separate change from you as we discussed offline. -- To view, visit http://gerrit.cloudera.org:8080/21563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6095f318e3d06dedb4197681156b40dd2a326c6f Gerrit-Change-Number: 21563 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 16 Jul 2024 14:51:27 +0000 Gerrit-HasComments: Yes
