Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )
Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc@429 PS1, Line 429: allows DELETE, UPDATE and MERGE operations We should include that these operations will be done with merge-on-read because Impala can't write with copy-on-write. http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py File tests/custom_cluster/test_iceberg_enable_merge_on_read.py: http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py@54 PS1, Line 54: MERGE We could add a TODO here with the Jira ticket for MERGE saying that once MERGE is available we should add a test for that too. -- To view, visit http://gerrit.cloudera.org:8080/21578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4 Gerrit-Change-Number: 21578 Gerrit-PatchSet: 1 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 17 Jul 2024 11:20:30 +0000 Gerrit-HasComments: Yes
