Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )
Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21578/2/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java File fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java: http://gerrit.cloudera.org:8080/#/c/21578/2/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java@80 PS2, Line 80: getModifyMode Nit: could extract it into a variable, also used on L75. -- To view, visit http://gerrit.cloudera.org:8080/21578 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4 Gerrit-Change-Number: 21578 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 Jul 2024 13:41:14 +0000 Gerrit-HasComments: Yes
