Daniel Becker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21591 )

Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split 
encoding
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21591/6//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21591/6//COMMIT_MSG@9
PS6, Line 9: This commit adds an EE test that checks that Impala returns the 
correct error message when it encounters a table that contains a parquet file 
with Byte Stream Split encoding.
Lines should be at most 72 characters in the commit message.


http://gerrit.cloudera.org:8080/#/c/21591/6/testdata/parquet_byte_stream_split_encoding/test_double.parquet
File testdata/parquet_byte_stream_split_encoding/test_double.parquet:

http://gerrit.cloudera.org:8080/#/c/21591/6/testdata/parquet_byte_stream_split_encoding/test_double.parquet@1
PS6, Line 1: PAR1 
,%æ²fi@%æ²fi@(%æ²fi@%æ²fi@4%æ²fi@&¢
We should add a README file in testdata/parquet_byte_stream_split_encoding that 
describes how these two parquet files were generated. See for example 
https://github.com/apache/impala/blob/master/testdata/parquet_nested_types_encodings/README



--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 6
Gerrit-Owner: Myktybek Sattarov <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:32:10 +0000
Gerrit-HasComments: Yes

Reply via email to