Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21591 )

Change subject: IMPALA-13211: Add negative test for Parquet Byte Stream Split 
encoding
......................................................................


Patch Set 9:

(16 comments)

http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py
File testdata/parquet_byte_stream_split_encoding/fileGenerator.py:

http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@7
PS9, Line 7: e
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@8
PS9, Line 8:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@8
PS9, Line 8:                use_byte_stream_split=True, use_dictionary=False)
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@13
PS9, Line 13: q
flake8: E501 line too long (96 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/fileGenerator.py@14
PS9, Line 14:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py
File testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py:

http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS9, Line 5:  
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@5
PS9, Line 5:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7: r
flake8: E501 line too long (128 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@7
PS9, Line 7: pq.write_table(float_table, 
'/home/sattarov/repos/pyArrow/test_float.parquet', use_byte_stream_split=True, 
use_dictionary=False)
line has trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS9, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@10
PS9, Line 10:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12: s
flake8: E501 line too long (130 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12:
flake8: W291 trailing whitespace


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12:
flake8: W292 no newline at end of file


http://gerrit.cloudera.org:8080/#/c/21591/9/testdata/parquet_byte_stream_split_encoding/parquet_files_generator.py@12
PS9, Line 12: pq.write_table(double_table, 
'/home/sattarov/repos/pyArrow/test_double.parquet', use_byte_stream_split=True, 
use_dictionary=False)
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/21591
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1ec19f06e5800d6c8f8502eb7728662013b73
Gerrit-Change-Number: 21591
Gerrit-PatchSet: 9
Gerrit-Owner: Myktybek Sattarov <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Myktybek Sattarov <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jul 2024 12:15:58 +0000
Gerrit-HasComments: Yes

Reply via email to