Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 )
Change subject: Make GetOperationStatus/get_state wait up to 5 seconds for completion ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19205/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19205/4//COMMIT_MSG@7 PS4, Line 7: 5 seconds Can you add a flag or query option for this? I think that a query option would be more ideal - for example if a client wants live progress, it could set it to a smaller value. But if it seems complex, the flag seems also useful, for example by setting it to a moderate value (0.5?), and setting a bigger value when benchmarking. http://gerrit.cloudera.org:8080/#/c/19205/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19205/4/be/src/service/client-request-state.cc@1795 PS4, Line 1795: exec_state() != ExecState::ERROR && shouldn't CANCALLED also exit this loop? Another way could be saving the current state and return when it is changed. -- To view, visit http://gerrit.cloudera.org:8080/19205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72ca595c5dd8a33b936f078f7f7faa5b3f0f337d Gerrit-Change-Number: 19205 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 19 Jul 2024 17:32:38 +0000 Gerrit-HasComments: Yes
