Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 )
Change subject: Make GetOperationStatus/get_state wait up to 5 seconds for completion ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19205/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19205/4//COMMIT_MSG@7 PS4, Line 7: 5 seconds > Can you add a flag or query option for this? Added a "long_polling_time_ms" query option http://gerrit.cloudera.org:8080/#/c/19205/4/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/19205/4/be/src/service/client-request-state.cc@1795 PS4, Line 1795: exec_state() != ExecState::ERROR && > shouldn't CANCALLED also exit this loop? There is a CANCELED state in the HS2 protocol, but I guess Impala server doesn't use it. ExecState is referring to ClientRequestState's ExecState, which doesn't include the CANCELED state: https://github.com/apache/impala/blob/master/be/src/service/client-request-state.h#L86 Do clients benefit from knowing about state transitions for INITIALIZED to PENDING or PENDING to RUNNING? In looking at impyla and impala-shell, I don't see them making a distinction between those states. A concern here would be that we return for a PENDING to RUNNING transition and it's a short query that then immediately does RUNNING to FINISHED. This would matter for waiting for admission control. We do that for our admission control tests via this function: https://github.com/apache/impala/blob/711a9f2bad84f92dc4af61d49ae115f0dc4239da/tests/beeswax/impala_beeswax.py#L429 -- To view, visit http://gerrit.cloudera.org:8080/19205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72ca595c5dd8a33b936f078f7f7faa5b3f0f337d Gerrit-Change-Number: 19205 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Sat, 27 Jul 2024 22:20:25 +0000 Gerrit-HasComments: Yes
