Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21045 )

Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong 
number
......................................................................


Patch Set 16: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21045/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21045/3//COMMIT_MSG@10
PS3, Line 10: partition event ,the metric will also be increased, besides for 
some
> nit: "event, the"
Please fix this.


http://gerrit.cloudera.org:8080/#/c/21045/3//COMMIT_MSG@11
PS3, Line 11: other cases like alter partition the event is skipped and the log 
is
> Can you add more details in this commit message about what all events are a
Please address this.



--
To view, visit http://gerrit.cloudera.org:8080/21045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a
Gerrit-Change-Number: 21045
Gerrit-PatchSet: 16
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jul 2024 07:42:32 +0000
Gerrit-HasComments: Yes

Reply via email to