Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21045 )
Change subject: IMPALA-12771: Impala catalogd events-skipped may mark the wrong number ...................................................................... Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@10 PS17, Line 10: fo nit: "of" http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@13 PS17, Line 13: with the : transactional table is in loading status I think we don't skip an event if the table is in loading state. Instead, we skip the event when the table is unloaded. What about changing this to: on the transactional table which is not in loaded state http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@16 PS17, Line 16: is in loading status also need changes http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@20 PS17, Line 20: really process "any real work" might be better http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@22 PS17, Line 22: is in loading status also need changes http://gerrit.cloudera.org:8080/#/c/21045/17//COMMIT_MSG@26 PS17, Line 26: ,create transactional table, nit: add space after comma -- To view, visit http://gerrit.cloudera.org:8080/21045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aeb04e999b82187eb138c0b643ead259da22f1a Gerrit-Change-Number: 21045 Gerrit-PatchSet: 17 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2024 07:10:43 +0000 Gerrit-HasComments: Yes
