Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21437 )
Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts when partition list is stale ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/21437/14/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21437/14/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1265 PS14, Line 1265: * If 'loadTableSchema' is true, the table schema is loaded from the Hive Metastore. : * : * If 'isPreLoadForInsert' is true, then we intend to refresh partitions from the Hive : * Metastore without reloading the file metadata(this is done in later steps) to ensure : * consistency while inserting into partitioned tables. : * > I have addressed this comment to the newly introduced method. Created https Done http://gerrit.cloudera.org:8080/#/c/21437/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21437/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7264 PS20, Line 7264: // 'partsToCreate' should be a pass-by-value argument as : // HdfsTable#updatePartitionsFromHms() may modify this HashSet if the : // partitions already exists is metastore but not in Impala's cache. : // Reason: 'partsToCreate' is used by HdfsTable#load() to reload file : // metadata of newly created partitions in Impala. : .setPartitionsToUpdate(new HashSet<>(partsToCreate)) Should this copying (new HashSet) moved to HdfsTableLoadParamsBuilder#setPartitionsToUpdate ? -- To view, visit http://gerrit.cloudera.org:8080/21437 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18 Gerrit-Change-Number: 21437 Gerrit-PatchSet: 20 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 24 Jul 2024 13:43:54 +0000 Gerrit-HasComments: Yes
