Sai Hemanth Gantasala has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21437 )

Change subject: IMPALA-12277: Fix NullPointerException for partitioned inserts 
when partition list is stale
......................................................................


Patch Set 21:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21437/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/21437/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7264
PS20, Line 7264: .setPartitionsToUpdate(partsToCreate)
               :                   .setDebugAction(update.getDebug_action())
               :                   .setReason("Preload for INSERT")
               :                   .setIsPreLoadForInsert(true)
               :                   .setCatalogTimeline(catalogTimeline)
               :                   .build());
> Should this copying (new HashSet) moved to HdfsTableLoadParamsBuilder#setPa
Ack



--
To view, visit http://gerrit.cloudera.org:8080/21437
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ide8f1f6bf017e9a040b53bb5d5291ff2ea3e0d18
Gerrit-Change-Number: 21437
Gerrit-PatchSet: 21
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jul 2024 17:26:18 +0000
Gerrit-HasComments: Yes

Reply via email to