Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21650 )
Change subject: IMPALA-12737: Add HS2 support to the InternalServer class. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21650/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21650/1//COMMIT_MSG@7 PS1, Line 7: suuport > nit: support Done http://gerrit.cloudera.org:8080/#/c/21650/1/be/src/service/internal-server.cc File be/src/service/internal-server.cc: http://gerrit.cloudera.org:8080/#/c/21650/1/be/src/service/internal-server.cc@286 PS1, Line 286: Status ImpalaServer::FetchAllRowsHS2(const TUniqueId& query_id, : vector<TRow>& query_results, results_columns* columns) { > This method share similar codes with ImpalaServer::FetchAllRows, except the I'm going to take a different approach. The ImpalaServer::FetchAllRows function is only called by ImpalaServer::ExecuteAndFetchAllText, and that function is not used by anything other than the unit tests for it. Thus, I am removing both those functions and leaving ImpalaServer::FetchAllRowsHS2 as-is since there won't be duplicate code anymore. -- To view, visit http://gerrit.cloudera.org:8080/21650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4b278b69ffb2beef3ea5bc1eb9335d9c27a5c8 Gerrit-Change-Number: 21650 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 17:52:59 +0000 Gerrit-HasComments: Yes
