Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21650 )
Change subject: IMPALA-12737: Add HS2 support to the InternalServer class. ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21650/2/be/src/service/internal-server.cc File be/src/service/internal-server.cc: http://gerrit.cloudera.org:8080/#/c/21650/2/be/src/service/internal-server.cc@34 PS2, Line 34: using namespace apache::hive::service::cli::thrift; > nit: might be a better idea to constrain this to specific classes, like que Done http://gerrit.cloudera.org:8080/#/c/21650/2/be/src/service/internal-server.cc@257 PS2, Line 257: 10 > Any reason behind fetch_size = 10? I believe impala-shell default to 8192 a This code was copied from the now deleted FetchAllRows function. That function in turn had a small limit because it was intended to only retrieve small amounts of data. I updated this to match the shell default of 8192 and moved it into a constant. -- To view, visit http://gerrit.cloudera.org:8080/21650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf4b278b69ffb2beef3ea5bc1eb9335d9c27a5c8 Gerrit-Change-Number: 21650 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2024 19:11:25 +0000 Gerrit-HasComments: Yes
