Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21652 )

Change subject: IMPALA-13280: Speed up test_under_statement_expression_limit
......................................................................


Patch Set 2:

(1 comment)

> Thanks for the fix. It seems we may need some following up work in the future 
> to let the fe/be to decide whether to disable the codegen for similar cases.

I will file follow up JIRA for that.

http://gerrit.cloudera.org:8080/#/c/21652/1/tests/query_test/test_exprs.py
File tests/query_test/test_exprs.py:

http://gerrit.cloudera.org:8080/#/c/21652/1/tests/query_test/test_exprs.py@147
PS1, Line 147: take
> nit. take
Done



--
To view, visit http://gerrit.cloudera.org:8080/21652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If91b973fef95a89cc24a9172fdf24e2f11a19e6d
Gerrit-Change-Number: 21652
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 08 Aug 2024 18:23:17 +0000
Gerrit-HasComments: Yes

Reply via email to