Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21652 )
Change subject: IMPALA-13280: Speed up test_under_statement_expression_limit ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21652/2/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/21652/2/tests/query_test/test_exprs.py@147 PS2, Line 147: # IMPALA-13280: Disable codegen because it will take 2GB+ of memory : # and over 30 minutes for doing codegen. The comments "IMPALA-13280: Disable codegen because it will take 2GB+ of memory and over 30 minutes for doing codegen." and old comments "This takes 20+ minutes, so only run it on exhaustive. TODO: Determine whether this needs to run serially. It uses >5 GB of memory." seem to overlap quite a lot. The latest one is more recent, maybe we could consider merging the comments. -- To view, visit http://gerrit.cloudera.org:8080/21652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If91b973fef95a89cc24a9172fdf24e2f11a19e6d Gerrit-Change-Number: 21652 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 08 Aug 2024 19:21:31 +0000 Gerrit-HasComments: Yes
