Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21646 )
Change subject: IMPALA-13240: Add gerrit comments for Thrift/FlatBuffers changes ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21646/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21646/3//COMMIT_MSG@17 PS3, Line 17: Adds a new option (--revision) for critique-gerrit-review.py to speci > nit: Add example on how to run the script in local machine. Done http://gerrit.cloudera.org:8080/#/c/21646/3/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/21646/3/bin/jenkins/critique-gerrit-review.py@353 PS3, Line 353: parser.add_argument("--dryrun", action='store_true', : help="Don't post comments back to gerrit") > Can we add argument so we can compare two non-consecutive hash? Done. It seems flake-diff works when I compare two revisions. So I just add one for specifying the base revision. -- To view, visit http://gerrit.cloudera.org:8080/21646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 Gerrit-Change-Number: 21646 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2024 01:54:42 +0000 Gerrit-HasComments: Yes
