Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21646 )
Change subject: IMPALA-13240: Add gerrit comments for Thrift/FlatBuffers changes ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/21646/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21646/4//COMMIT_MSG@27 PS4, Line 27: -revision > nit: --revision Done http://gerrit.cloudera.org:8080/#/c/21646/4/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/21646/4/bin/jenkins/critique-gerrit-review.py@77 PS4, Line 77: # Thrift files that are not used in communication between impalad and catalogd/statestore : EXCLUDE_THRIFT_FILES > I think this script should warn if there is a new 'include "XXX.thrift"' li Good point! http://gerrit.cloudera.org:8080/#/c/21646/4/bin/jenkins/critique-gerrit-review.py@306 PS4, Line 306: comments[curr_file].append( : {"message": "Modifying/adding this required field might break the compatibility" : " between impalad and catalogd/statestore during upgrade", : "line": new_line_num}) > It will be great if we can have a method to compose CommentInput and consis In our Gerrit version (2.14.15), CommentInfo doesn't have 'context_line' yet. https://gerrit.cloudera.org/Documentation/rest-api-changes.html#comment-info To be simple, I add a "context_line" field to CommentInput when dryrun=True as this is only read by developers. http://gerrit.cloudera.org:8080/#/c/21646/4/bin/jenkins/critique-gerrit-review.py@360 PS4, Line 360: "--base_revision" > nit: better to use dash consistently. "--base-revision" Done -- To view, visit http://gerrit.cloudera.org:8080/21646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 Gerrit-Change-Number: 21646 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 13 Aug 2024 07:10:42 +0000 Gerrit-HasComments: Yes
