Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21655 )
Change subject: IMPALA-13293: Fix too long wait for initial catalog update ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/catalog/FeCatalog.java File fe/src/main/java/org/apache/impala/catalog/FeCatalog.java: http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/catalog/FeCatalog.java@103 PS3, Line 103: void waitForCatalogUpdate(long timeoutMs); > It is actually used after startup at a single call site: Ack http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@425 PS3, Line 425: } > If the timeout is reached, then it may not be ready at this point. Both pla Ack http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1882 PS3, Line 1882: * @see ImpaladCatalog#isReady() nit: we can also add CatalogdMetaProvider#isReady() in this comment -- To view, visit http://gerrit.cloudera.org:8080/21655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4da1d0c0d25f80b02c39be863431201d1b913c5d Gerrit-Change-Number: 21655 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Aug 2024 00:15:18 +0000 Gerrit-HasComments: Yes
