Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21655 )

Change subject: IMPALA-13293: Fix too long wait for initial catalog update
......................................................................


Patch Set 4: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/21655/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1889
PS3, Line 1889:     while (true) {
              :       // Avoid calling getCatalog again in this attempt as
> I thought that it is easier to understand this way.
Thanks for the explanation (though I might have understood only half of it). 
I'm OK with keeping this change minimal, which is probably safer as well, 
though it'd be nice to make this logic clearer/simpler in the future.



--
To view, visit http://gerrit.cloudera.org:8080/21655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4da1d0c0d25f80b02c39be863431201d1b913c5d
Gerrit-Change-Number: 21655
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 14 Aug 2024 13:49:56 +0000
Gerrit-HasComments: Yes

Reply via email to