Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21574/3/tests/webserver/test_web_pages.py@898 PS3, Line 898: \ > '\' is used to escape left parenthesis. Let's use Python’s raw string notation for regular expression patterns, e.g. r"(?<!{{ __common__.host-url }})(?<!make_url\(\")/www/.*" -- To view, visit http://gerrit.cloudera.org:8080/21574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522 Gerrit-Change-Number: 21574 Gerrit-PatchSet: 3 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 14 Aug 2024 02:08:04 +0000 Gerrit-HasComments: Yes
