Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21574 )
Change subject: IMPALA-13196 (part2): fix some urls in template files ...................................................................... Patch Set 4: (3 comments) Thanks for adding the tests, the patch seems fine. Only some nits from my side. http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl File www/query_plan_text.tmpl: http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_plan_text.tmpl@29 PS4, Line 29: import nit: line too long.. http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl File www/query_profile.tmpl: http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_profile.tmpl@49 PS4, Line 49: from nit: line too long http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl File www/query_stmt.tmpl: http://gerrit.cloudera.org:8080/#/c/21574/4/www/query_stmt.tmpl@39 PS4, Line 39: import {inflateParseJSON} from "{{ __common__.host-url }}/www/scripts/compression_util.js"; nit: line too long -- To view, visit http://gerrit.cloudera.org:8080/21574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If53947c3b8429840990b361a936ba31e1df21522 Gerrit-Change-Number: 21574 Gerrit-PatchSet: 4 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 03:40:52 +0000 Gerrit-HasComments: Yes
