Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21646 )
Change subject: IMPALA-13240: Add gerrit comments for Thrift/FlatBuffers changes ...................................................................... Patch Set 7: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21646/5/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/21646/5/bin/jenkins/critique-gerrit-review.py@48 PS5, Line 48: import vir > Yeah, removed it. Done http://gerrit.cloudera.org:8080/#/c/21646/5/bin/jenkins/critique-gerrit-review.py@342 PS5, Line 342: elif check_source_file: > Oops, this is due to is_thrift_file=False when goes here.. Resolved the iss Done http://gerrit.cloudera.org:8080/#/c/21646/7/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/21646/7/bin/jenkins/critique-gerrit-review.py@349 PS7, Line 349: is not None nit: can be removed as well? -- To view, visit http://gerrit.cloudera.org:8080/21646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib35fafa50bfd38631312d22464df14d426f55346 Gerrit-Change-Number: 21646 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 02:34:21 +0000 Gerrit-HasComments: Yes
