Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/exec/tuple-cache-node.h File be/src/exec/tuple-cache-node.h: http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/exec/tuple-cache-node.h@21 PS4, Line 21: #include <vector> Why include vector in this header? http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/scheduling/scheduler.cc@600 PS4, Line 600: bool operator<(InstanceAssignment& other) const { return weight > other.weight; } Make this deterministic for equal weight case by comparing instance_idx. http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/scheduling/scheduler.cc@816 PS4, Line 816: return ScanRangeWeight(a) > ScanRangeWeight(b); Make this deterministic for equal weight http://gerrit.cloudera.org:8080/#/c/21541/4/be/src/scheduling/scheduler.cc@821 PS4, Line 821: pop_heap(instance_heap.begin(), instance_heap.end()); Kind of hard to follow why pop_heap/push_heap is being used here instead of just updating and sorting the vector. Also why isn't make_heap needed? http://gerrit.cloudera.org:8080/#/c/21541/4/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java File fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java: http://gerrit.cloudera.org:8080/#/c/21541/4/fe/src/main/java/org/apache/impala/planner/TupleCacheNode.java@128 PS4, Line 128: output.append(detailPrefix + "input scan node ids: " + If this list will typically be long, it should be split at keyFormatWidth -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 15:09:27 +0000 Gerrit-HasComments: Yes
