Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 6: (2 comments) I'm working on a test case, but here's updated code. http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc@601 PS6, Line 601: if (a_hdfs_split.mtime() > b_hdfs_split.mtime()) return true; > I think this is insufficient. If a.mtime < b.mtime and a.offset > b.offset, Good point, changed to look like: if (x.field != y.field) { return x.field > y.field; } http://gerrit.cloudera.org:8080/#/c/21541/6/be/src/scheduling/scheduler.cc@637 PS6, Line 637: // To make this determinstic, break ties by comparing the instance idxs > nit: deterministic Done -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 20:45:12 +0000 Gerrit-HasComments: Yes
