Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21684
Change subject: IMPALA-13302: Restore registering all conjuncts ...................................................................... IMPALA-13302: Restore registering all conjuncts Reverts an optimization in IMPALA-12164 that skipped registering remaining conjuncts if they were expected to be removed by a rewrite rule. However that rewrite rule would not always be applied during the first pass, which could result in duplicate Expr ID assignment during a reAnalyze pass that led to skipping slot materialization because the analyzer thought a new expression was already assigned. Centralizes trace logging new expressions created by rewrite rules to assist in debugging. Adds ExprRewriteRules tests that previously hit the new Precondition in markConjunctAssigned, and rewrite PlannerTest. Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 --- M fe/src/main/java/org/apache/impala/analysis/Analyzer.java M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M fe/src/test/java/org/apache/impala/planner/PlannerTest.java A testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test 6 files changed, 143 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/84/21684/1 -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]>
