Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 )
Change subject: IMPALA-13302: Restore registering all conjuncts ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21684/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21684/1/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1976 PS1, Line 1976: foundConstantFalse = true; There is a cost associated with running BetweenToCompoundRule and FeSupport.EvalPredicate inside markConstantConjunct. If foundConstantFalse turns into 'true', and the remaining conjuncts are expected to be written out, is it possible to stop markConstantConjunct right after L2000 for the remaining conjuncts? -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 23:27:51 +0000 Gerrit-HasComments: Yes
