Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21687 )
Change subject: IMPALA-5443: apply codegen rows threshold per node ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21687/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21687/2//COMMIT_MSG@9 PS2, Line 9: Switches `disable_codegen_rows_threshold` to apply to each plan node I suspect with this change we'd want to lower the threshold. I'd suggest 10k rows. Alternatively we can add a separate query option to control this. If we change the behavior here, it's certainly something we'll want to call out in release notes, but making it a new query option that you need to opt into will limit any potential improvement. -- To view, visit http://gerrit.cloudera.org:8080/21687 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b34d4f2ef0d98fcd918a8a546acde70e09d18d7 Gerrit-Change-Number: 21687 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 22:31:24 +0000 Gerrit-HasComments: Yes
