Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21687
to look at the new patch set (#3).
Change subject: IMPALA-5443: Apply codegen rows threshold per node
......................................................................
IMPALA-5443: Apply codegen rows threshold per node
Switches `disable_codegen_rows_threshold` to apply to each plan node
rather than the whole query. Individual nodes may skip codegen if they
expect to process only a small number of rows.
The default for `disable_codegen_rows_threshold` is lowered to 10k rows
as it can now apply to a lot more queries.
If no plan nodes in a fragment use codegen, then the whole fragment will
be disabled. This skips all steps of codegen and prints "Codegen
Disabled" in the query profile.
ParallelPlanner adds fragments after PlanNodeCodegenVisitor, so we
ensure any new fragments are marked if they have codegen plan nodes.
Change-Id: I1b34d4f2ef0d98fcd918a8a546acde70e09d18d7
---
M be/src/runtime/fragment-state.h
M common/thrift/Planner.thrift
M common/thrift/Query.thrift
M fe/src/main/java/org/apache/impala/planner/DataSourceScanNode.java
M fe/src/main/java/org/apache/impala/planner/ParallelPlanner.java
M fe/src/main/java/org/apache/impala/planner/PlanFragment.java
M fe/src/main/java/org/apache/impala/planner/PlanNode.java
M fe/src/main/java/org/apache/impala/planner/Planner.java
M fe/src/main/java/org/apache/impala/planner/ScanNode.java
M fe/src/main/java/org/apache/impala/util/MaxRowsProcessedVisitor.java
A fe/src/main/java/org/apache/impala/util/PlanNodeCodegenVisitor.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ExecRequestCreator.java
12 files changed, 157 insertions(+), 68 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/21687/3
--
To view, visit http://gerrit.cloudera.org:8080/21687
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1b34d4f2ef0d98fcd918a8a546acde70e09d18d7
Gerrit-Change-Number: 21687
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>