Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21688 )

Change subject: IMPALA-13262: Do not always migrate inferred predicates into 
inline view
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21688/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

http://gerrit.cloudera.org:8080/#/c/21688/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@1567
PS1, Line 1567: if (isAnalytic)
It is probably enough to check for equality between leftParent and rightParent 
here without resolving the table.

if (isAnalytic && leftParent.equals(rightParent))



--
To view, visit http://gerrit.cloudera.org:8080/21688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2632b3b1a140ae0104ceba4e2f474ac1bbcda1
Gerrit-Change-Number: 21688
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 20 Aug 2024 00:28:11 +0000
Gerrit-HasComments: Yes

Reply via email to