Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21688 )

Change subject: IMPALA-13262: Do not always migrate inferred predicates into 
inline view
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21688/2/testdata/workloads/functional-query/queries/QueryTest/inline-view.test
File testdata/workloads/functional-query/queries/QueryTest/inline-view.test:

http://gerrit.cloudera.org:8080/#/c/21688/2/testdata/workloads/functional-query/queries/QueryTest/inline-view.test@597
PS2, Line 597: # IMPALA-13262: Do not migrate an inferred predicate into an 
inline view if both sides of
             : # the inferred predicate reference the same base table.
Please add one more test:

SELECT * FROM
(
SELECT year, id, int_col, ROW_NUMBER() over(PARTITION BY year ORDER BY id DESC) 
rn
FROM (select * from functional.alltypes UNION ALL select * from 
functional.alltypes) allt
) iv
WHERE rn > 7200 and iv.id = iv.int_col

This should return 20 rows.



--
To view, visit http://gerrit.cloudera.org:8080/21688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e2632b3b1a140ae0104ceba4e2f474ac1bbcda1
Gerrit-Change-Number: 21688
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Tue, 20 Aug 2024 22:27:11 +0000
Gerrit-HasComments: Yes

Reply via email to