Andrew Sherman has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/21700


Change subject: IMPALA-13310 Add the value of the http 'X-Forwarded-For' header 
to the runtime profile
......................................................................

IMPALA-13310 Add the value of the http 'X-Forwarded-For' header to the runtime 
profile

When using hs2-http protocol, http messages from Impala clients may pass
through one or more proxies before reaching the Impala coordinator.
This can make it harder to track the origin of the http messages. The
X-Forwarded-For header is added or edited by HTTP proxies when
forwarding a request. Add the value of this header to the runtime
profile so that it can be observed. Note that Impala does not do any
verification of this value, so its value should only be trusted if the
deployment environment protects against spoofing.

To test this, add an option '--hs2_x_forward' to impala-shell which will
set the X-Forwarded-For header. Add a test which verifies that the value
is set in the profile.

Change-Id: I2e010cfb09674c5d043ef915347c3836696e03cf
---
M be/src/rpc/authentication.cc
M be/src/rpc/thrift-server.h
M be/src/service/client-request-state.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M be/src/transport/THttpServer.cpp
M be/src/transport/THttpServer.h
M shell/impala_client.py
M shell/impala_shell.py
M shell/option_parser.py
M tests/shell/test_shell_commandline.py
11 files changed, 61 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/21700/1
--
To view, visit http://gerrit.cloudera.org:8080/21700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e010cfb09674c5d043ef915347c3836696e03cf
Gerrit-Change-Number: 21700
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <[email protected]>

Reply via email to