Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21700 )
Change subject: IMPALA-13310 Add the value of the http 'X-Forwarded-For' header to the runtime profile ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21700/3/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/21700/3/be/src/transport/THttpServer.cpp@167 PS3, Line 167: origin_ = value; https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For#parsing says "There may be multiple X-Forwarded-For headers present in a request.". What happen if there is multiple 'X-Forwarded-For' header like follows: X-Forwarded-For: 1.1.1.1 X-Forwarded-For: 2.2.2.2 Looks like this only store the last one? -- To view, visit http://gerrit.cloudera.org:8080/21700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e010cfb09674c5d043ef915347c3836696e03cf Gerrit-Change-Number: 21700 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 18:12:16 +0000 Gerrit-HasComments: Yes
