Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21662 )

Change subject: IMPALA-12758: Event processor is ignoring the prev_id while 
reloading existing partitions
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1324
PS1, Line 1324:     EventProcessorUtils.wait_for_event_processing(self)
> This patch is valid when enable_sync_to_latest_event_on_ddls=true, Since IM
The bug is there without the patch of IMPALA-10976. I think we should be able 
to add a test. Or could you explain why the bug can't be reproduced by a test?


http://gerrit.cloudera.org:8080/#/c/21662/2/tests/custom_cluster/test_events_custom_configs.py
File tests/custom_cluster/test_events_custom_configs.py:

http://gerrit.cloudera.org:8080/#/c/21662/2/tests/custom_cluster/test_events_custom_configs.py@1326
PS2, Line 1326: \
> flake8: W605 invalid escape sequence '\('
use the raw string format to get rid of these warnings, i.e.

 r"Invalidated objects in cache: \[partition %s:p=\d \(id=%%d\)\]"



--
To view, visit http://gerrit.cloudera.org:8080/21662
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610
Gerrit-Change-Number: 21662
Gerrit-PatchSet: 2
Gerrit-Owner: Sai Hemanth Gantasala <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 22 Aug 2024 07:21:21 +0000
Gerrit-HasComments: Yes

Reply via email to