Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21662 )
Change subject: IMPALA-12758: Event processor is ignoring the prev_id while reloading existing partitions ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@876 PS4, Line 876: public long getPrevId() { : return prevId_; : } Do we use this somewhere? http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21662/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@3036 PS4, Line 3036: public void reloadPartitions(IMetaStoreClient client, If you check the call graphs of this method, you'll see it's not just used by the event-processor, but also used by REFRESH with partition spec. HdfsTable.reloadPartitions(IMetaStoreClient, Map<Partition, HdfsPartition>, boolean, EventSequence)(2 usages) (org.apache.impala.catalog) CatalogServiceCatalog.reloadHdfsPartition(HdfsTable, String, Reference<Boolean>, ThriftObjectType, String, long, HdfsPartition, ...) (org.apache.impala.catalog) CatalogServiceCatalog.reloadPartition(Table, List<TPartitionKeyValue>, Reference<Boolean>, ThriftObjectType, String, EventSequence) (org.apache.impala.catalog) CatalogOpExecutor.execResetMetadataImpl(TResetMetadataRequest) (org.apache.impala.service) CatalogOpExecutor.execResetMetadata(TResetMetadataRequest) (org.apache.impala.service) So we can add a test on REFRESH with partition spec, e.g. REFRESH functional.alltypes PARTITION (year=2009, month=1). The test should run in local catalog mode: * SHOW PARTITIONS functional.alltypes - make sure all partitions are loaded in both catalogd and coordinator side * REFRESH functional.alltypes PARTITION (year=2009, month=1) * Wait 2s and see if there are logs like CatalogdMetaProvider.java:1680] Invalidated objects in cache: [partition functional.alltypes:year=2009/month=1 (id=xxx)] http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21662/1/tests/custom_cluster/test_events_custom_configs.py@1324 PS1, Line 1324: self.client.execute("select * from {}".format(test_tbl)) > Ack Post an idea of how to add a test in another comment -- To view, visit http://gerrit.cloudera.org:8080/21662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610 Gerrit-Change-Number: 21662 Gerrit-PatchSet: 4 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 20 Sep 2024 08:06:24 +0000 Gerrit-HasComments: Yes
