Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21679 )
Change subject: IMPALA-13302: Analyze new rewrite exprs ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21679/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21679/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3348 PS5, Line 3348: If we're marking it now, that can cause conflicts : // with an Expr that gets assigned the same ID, usually skipping slot materialization. > I'll have to take a look at that again. It can definitely cause problems if I don't think it's valid to try to call this function on multiple Expr sharing the same ExprID. It may be ok to re-use the same ID across multiple expressions, but re-analysis shouldn't try to markConjunctAssigned both. And this patch seems to avoid that. -- To view, visit http://gerrit.cloudera.org:8080/21679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028 Gerrit-Change-Number: 21679 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 21:44:18 +0000 Gerrit-HasComments: Yes
