Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21679 )
Change subject: IMPALA-13344: Analyze new rewrite exprs ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/21679/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21679/5/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@3348 PS5, Line 3348: (conjunct)) { : BinaryPredicate binaryPred = (BinaryPredicate) conjunct; > I think https://gerrit.cloudera.org/c/21684 is more correct. We shouldn't b +1 for https://gerrit.cloudera.org/c/21684/ is more correct after debugging this deeper. The expr ids should be consistent inside a GlobalState instance. Registering a conjunct assigns a new expr id to it and ensures it's unique in the scope of the current Analyzer. If we skip registering a conjunct but mark it as assigned, we are marking an undefined expr id (usually previously assigned in previous analyzers) as assigned. This would accidentally mark a later registered conjunct as assigned. Then we miss it in materializeRequiredSlots(). -- To view, visit http://gerrit.cloudera.org:8080/21679 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028 Gerrit-Change-Number: 21679 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2024 09:38:43 +0000 Gerrit-HasComments: Yes
