Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21541 )
Change subject: IMPALA-12906: Incorporate scan range information into the tuple cache key ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc File be/src/scheduling/scheduler.cc: http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc@593 PS7, Line 593: if (a_weight != b_weight) return a_weight > b_weight; > Done Ack http://gerrit.cloudera.org:8080/#/c/21541/7/be/src/scheduling/scheduler.cc@603 PS7, Line 603: const HdfsFileSplitPB& a_hdfs_split = a.scan_range().hdfs_file_split(); > In terms of generated code, for const accessor methods on const references, My point was related to the comment at lines 601-602. This is fine unless we see actually measurable perf problems. I'm pleasantly surprised if the compiler optimizes these to a single function call each. -- To view, visit http://gerrit.cloudera.org:8080/21541 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe298fff0f644ce931a2aa934ebb98f69aab9d34 Gerrit-Change-Number: 21541 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 22:55:06 +0000 Gerrit-HasComments: Yes
