Jason Fehr has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21744 )
Change subject: IMPALA-13347: Fixes TSAN Thread Leak of Workload Management Thread ...................................................................... IMPALA-13347: Fixes TSAN Thread Leak of Workload Management Thread The workload management processing runs in a separate thread declared in impala-server.h. This thread runs until a graceful shutdown is initiated. The last step of the Impala coordinator shutdown process is to drain the completed queries queue to the query log table thus ensuring completed queries do not get lost. This thread has to run to completion, but the coordinator shutdown process never joins that thread. This patch adds the joining of that thread during the coordinator shutdown process. If the workload management shutdown process exceedes the allotted time, the thread is detached. Info level logging was added to indicate which completed queries queue drain situation occurred - successful or timed out. A new custom cluster test was added to test the situation where the completed queries queue drain process times out. Change-Id: I1e95967bb6e04470a8900c9ba69080eea8aaa25e Reviewed-on: http://gerrit.cloudera.org:8080/21744 Reviewed-by: Riza Suminto <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/service/workload-management-init.cc M be/src/service/workload-management.cc M be/src/service/workload-management.h M tests/custom_cluster/test_query_log.py 6 files changed, 108 insertions(+), 17 deletions(-) Approvals: Riza Suminto: Looks good to me, approved Michael Smith: Looks good to me, but someone else must approve Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I1e95967bb6e04470a8900c9ba69080eea8aaa25e Gerrit-Change-Number: 21744 Gerrit-PatchSet: 10 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
