Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21744 )

Change subject: IMPALA-13347: Fixes TSAN Thread Leak of Workload Management 
Thread
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc
File be/src/service/workload-management.cc:

http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@118
PS2, Line 118:     completed_queries_cv_.notify_all();
> If the wait_for function times out, it returns no matter the result of the
Oh right, I spaced and overlooked that it takes 'l' as an argument.



--
To view, visit http://gerrit.cloudera.org:8080/21744
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e95967bb6e04470a8900c9ba69080eea8aaa25e
Gerrit-Change-Number: 21744
Gerrit-PatchSet: 6
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Wed, 04 Sep 2024 18:52:47 +0000
Gerrit-HasComments: Yes

Reply via email to