Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21556 )
Change subject: IMPALA-13182: Support uploading additional jars ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/21556/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21556/4//COMMIT_MSG@17 PS4, Line 17: * Tested manually Please add details about how the manual tests were run. For example, how did you assert that Impala can see the additional JARs on the classpath and use classes from those JARs? http://gerrit.cloudera.org:8080/#/c/21556/4/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/21556/4/docker/daemon_entrypoint.sh@117 PS4, Line 117: /opt/impala/aux-jars Impala has a bias towards high configurability with sensible defaults. It would be preferable to make this path configurable with '/opt/impala/aux-jars' being the default. http://gerrit.cloudera.org:8080/#/c/21556/4/docker/daemon_entrypoint.sh@120 PS4, Line 120: CLASSPATH+=:$jar > Good point. If the PATH variable already has a ':' at the end, then this co Ah, yes, the previous code ensures the CLASSPATH does not end with a colon. -- To view, visit http://gerrit.cloudera.org:8080/21556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica5fa4c0cd1a5c938f331f3a4bba85d4910db90e Gerrit-Change-Number: 21556 Gerrit-PatchSet: 4 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2024 17:34:46 +0000 Gerrit-HasComments: Yes
