Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21775 )
Change subject: IMPALA-13372: Declare batch_size dimension for count_star tests ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21775/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21775/1//COMMIT_MSG@12 PS1, Line 12: dimension and let vector permutation run the test twice for different > typo: and and Done http://gerrit.cloudera.org:8080/#/c/21775/1//COMMIT_MSG@17 PS1, Line 17: in test_min_multiple_distinct are dropped. cluster_sizes parameter in > The cluster_sizes parameter was meant to be something tests could increment It is for consistency reason. I see that that exercising ALL_CLUSTER_SIZES is achievable through create_exec_option_dimension(). Today, only TestAggregation use cluster_sizes parameter from ImpalaTestSuite.add_test_dimensions(). Other 17 py.test files declare num_nodes option via cluster_sizes arg of create_exec_option_dimension(). http://gerrit.cloudera.org:8080/#/c/21775/1//COMMIT_MSG@20 PS1, Line 20: are dropped and replaced by declaration using > typo: droped Done -- To view, visit http://gerrit.cloudera.org:8080/21775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b0399ee3b39a5b0bbfdf8a05680ab1fb23d8f87 Gerrit-Change-Number: 21775 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 00:35:44 +0000 Gerrit-HasComments: Yes
