Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21775 )
Change subject: IMPALA-13372: Declare batch_size dimension for count_star tests ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21775/2/tests/query_test/test_aggregation.py File tests/query_test/test_aggregation.py: http://gerrit.cloudera.org:8080/#/c/21775/2/tests/query_test/test_aggregation.py@360 PS2, Line 360: default batch_size, : and batch_size=1. would it be better to say, batch_size=0 and 1? Or mention that default batch_size is 0? -- To view, visit http://gerrit.cloudera.org:8080/21775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b0399ee3b39a5b0bbfdf8a05680ab1fb23d8f87 Gerrit-Change-Number: 21775 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 17:10:25 +0000 Gerrit-HasComments: Yes
