Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21780 )
Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs ...................................................................... Patch Set 1: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21780/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/21780/1/tests/authorization/test_ranger.py@79 PS1, Line 79: + flake8: W504 line break after binary operator http://gerrit.cloudera.org:8080/#/c/21780/1/tests/authorization/test_ranger.py@102 PS1, Line 102: r flake8: F841 local variable 'result' is assigned to but never used http://gerrit.cloudera.org:8080/#/c/21780/1/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21780/1/tests/common/custom_cluster_test_suite.py@406 PS1, Line 406: l flake8: F632 use ==/!= to compare constant literals (str, bytes, int, float, tuple) -- To view, visit http://gerrit.cloudera.org:8080/21780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab Gerrit-Change-Number: 21780 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2024 23:20:05 +0000 Gerrit-HasComments: Yes
