Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21780 )
Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21780/2/be/src/rpc/authentication.cc File be/src/rpc/authentication.cc: http://gerrit.cloudera.org:8080/#/c/21780/2/be/src/rpc/authentication.cc@151 PS2, Line 151: DEFINE_bool(use_xff_address_as_origin, false, > Since the X-Forwarded-For header is non-standard, please add some wording a Done http://gerrit.cloudera.org:8080/#/c/21780/2/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/21780/2/tests/authorization/test_ranger.py@95 PS2, Line 95: args = ['--protocol=hs2-http', > Please add a couple more test cases to ensure string parsing works as expec Done. Note that we don't validate the IP address but just read it as is from XFF. So for the "invalid" XFF header we're still reading "foobar" and adding it to the audit logs. http://gerrit.cloudera.org:8080/#/c/21780/2/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/21780/2/tests/common/custom_cluster_test_suite.py@388 PS2, Line 388: > Nit: A better place for this method (if it is being kept) is in impala_test Done -- To view, visit http://gerrit.cloudera.org:8080/21780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab Gerrit-Change-Number: 21780 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 23:46:31 +0000 Gerrit-HasComments: Yes
