Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21778 )
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... IMPALA-13371: Avoid throwing exception in FindFileInPath() Some boost::filesystem:: functions can throw exceptions, which led to crash without informative error when FileSystemUtil::FindFileInPath() bumped into a problematic path in JavaAddJammAgent(). Fixed by switching to overloads of the functions that can't throw exception (other functions in FileSystemUtil already used these). Testing: - Added tests with paths where Impala has no permissions (/root) Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Reviewed-on: http://gerrit.cloudera.org:8080/21778 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/common/init.cc M be/src/util/filesystem-util-test.cc M be/src/util/filesystem-util.cc M be/src/util/filesystem-util.h 4 files changed, 65 insertions(+), 30 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
