Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21778 )
Change subject: IMPALA-13371: Avoid throwing exception in FindFileInPath() ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21778/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21778/4//COMMIT_MSG@9 PS4, Line 9: boost::filesystem > Thanks for spotting this - I thought that we use std:: functions after gett Now that we're on C++17, we could switch to std::filesystem. But haven't started that process yet. -- To view, visit http://gerrit.cloudera.org:8080/21778 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ed9f288ac5c400778a6b1215e16baf191bf5d0c Gerrit-Change-Number: 21778 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2024 16:53:08 +0000 Gerrit-HasComments: Yes
