Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21792 )
Change subject: IMPALA-13322: Fix alter on SystemTables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21792/3/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21792/3/be/src/exec/system-table-scanner.cc@373 PS3, Line 373: return Status(Substitute("Unknown column (position $0) added to table", > In the scenario of two Impala clusters sharing catalogd and statestore, if That makes sense to me. I'll update it, probably log a warning. http://gerrit.cloudera.org:8080/#/c/21792/3/fe/src/main/java/org/apache/impala/catalog/SystemTable.java File fe/src/main/java/org/apache/impala/catalog/SystemTable.java: http://gerrit.cloudera.org:8080/#/c/21792/3/fe/src/main/java/org/apache/impala/catalog/SystemTable.java@118 PS3, Line 118: Table.LOADING_TABLES.decrementAndGet(); > We need a finally-clause for this since parseColumnType() could throw excep Ok, I was actually thinking more about this last night. For IMPALA-915, we want some way to interrupt Frontend threads, and that may require introducing some new exceptions. So making sure cleanup that needs to happen is in a finally block seems like a good general practice. -- To view, visit http://gerrit.cloudera.org:8080/21792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a59e58c086e659941e0db8a2b893ac6dcc5143a Gerrit-Change-Number: 21792 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2024 16:38:46 +0000 Gerrit-HasComments: Yes
