Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21792 )
Change subject: IMPALA-13322: Fix alter on SystemTables ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21792/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21792/3//COMMIT_MSG@12 PS3, Line 12: Please add info on how this patch was tested. http://gerrit.cloudera.org:8080/#/c/21792/3/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/21792/3/tests/custom_cluster/test_query_live.py@216 PS3, Line 216: def test_alter(self): I would prefer if this entire test was wrapped in a try..finally code block where the finally either executes alter table sys.impala_query_live drop column test_alter or drops the entire sys.impala_query_live table to ensure this table is not left in an invalid state. -- To view, visit http://gerrit.cloudera.org:8080/21792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a59e58c086e659941e0db8a2b893ac6dcc5143a Gerrit-Change-Number: 21792 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2024 20:47:33 +0000 Gerrit-HasComments: Yes
