Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21792 )
Change subject: IMPALA-13322: Fix alter on SystemTables ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/21792/6/be/src/exec/system-table-scanner.cc File be/src/exec/system-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/21792/6/be/src/exec/system-table-scanner.cc@373 PS6, Line 373: default: > I think we need this if we want to return NULL: I guess general question: do we want a default unset value or NULL specifically? There are several other columns where we leave it unmodified rather than returning NULL. NULL does seem more appropriate in this instance though, so I'll update it. http://gerrit.cloudera.org:8080/#/c/21792/6/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/21792/6/tests/custom_cluster/test_query_live.py@231 PS6, Line 231: '' > Shouldn't this be NULL? What if 'test_alter' is a numeric column? In this test it's not. But I'll update to NULL. Are you suggesting we should also test other column types? -- To view, visit http://gerrit.cloudera.org:8080/21792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a59e58c086e659941e0db8a2b893ac6dcc5143a Gerrit-Change-Number: 21792 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 13 Sep 2024 15:18:47 +0000 Gerrit-HasComments: Yes
