Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10402 )

Change subject: IMPALA-7029: Clone LHS when rewriting a between predicate
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
File fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java:

http://gerrit.cloudera.org:8080/#/c/10402/1/fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java@47
PS1, Line 47:           bp.getChild(0).clone(), bp.getChild(1));
even cleaner to clone all children



--
To view, visit http://gerrit.cloudera.org:8080/10402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2db3af99593bc207ee8dc2a1550acf21ebd61c41
Gerrit-Change-Number: 10402
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Tianyi Wang <[email protected]>
Gerrit-Comment-Date: Tue, 15 May 2018 01:16:32 +0000
Gerrit-HasComments: Yes

Reply via email to